fix: disable pending message retry on app open - #5211
Closed
MohamadJaara wants to merge 1 commit into
Closed
MohamadJaara wants to merge 1 commit into
MohamadJaara wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5211 +/- ##
===========================================
- Coverage 52.46% 52.40% -0.07%
===========================================
Files 740 740
Lines 25735 25733 -2
Branches 4223 4222 -1
===========================================
- Hits 13502 13485 -17
- Misses 10942 10957 +15
Partials 1291 1291
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Test Results2 620 tests ±0 2 620 ✅ ±0 1m 49s ⏱️ +24s Results for commit 97c1a4a. ± Comparison against base commit 18b1028. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
MohamadJaara
force-pushed
the
mo/disable-pending-retry-develop
branch
from
August 31, 2026 12:23
97c1a4a to
11a2859
Compare
Member
Author
|
already fixed in develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Prevent the foreground pending-message replay introduced in 4.32 from crashing the app when a persisted pending row contains content that cannot be encoded.
Reproduction
Change
A follow-up will harden pending-message encoding and re-enable the foreground trigger safely.